Add Google::getScopeInline(). #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying each scope as a separate array value in config instead of an array with single space separated string.
|
Restarting tests |
|
Any particular reason you have used |
|
Ping, I think this is good to merge :) |
|
My macbook is broken (waiting from service center). I will try to find another pc today to merge it and test. |
|
Sounds like 1st world problem :) |
|
I am sorry for delay. Still w8ting for my macbook :( They promise that I will get it tomorrow... |
|
LGTM, Thank you for patch, you are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Type: enhancement
Link to issue:
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
This allows specifying each scope as a separate array value in config
instead of an array with single space separated string.
Thanks 😺