Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: KPI 3 Pourcentage de personnes qui obtiennent un résultat conventionnel dans les pages personnalisables (contributions) #177

Conversation

FabienRoussel
Copy link
Contributor

No description provided.

@FabienRoussel FabienRoussel changed the title feat: KPI 3 Pourcentage de personnes qui obtiennent un résultat conventionnel dans les pages personnalisables (contributions) WIP feat: KPI 3 Pourcentage de personnes qui obtiennent un résultat conventionnel dans les pages personnalisables (contributions) May 4, 2022
@FabienRoussel FabienRoussel changed the title WIP feat: KPI 3 Pourcentage de personnes qui obtiennent un résultat conventionnel dans les pages personnalisables (contributions) feat: KPI 3 Pourcentage de personnes qui obtiennent un résultat conventionnel dans les pages personnalisables (contributions) May 24, 2022
Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Génial les tests unitaires, ça explique tout le code, c'est vraiment top !!

package-lock.json Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
src/commands.ts Outdated Show resolved Hide resolved
src/commands.ts Outdated Show resolved Hide resolved
src/analysis/kpi.ts Show resolved Hide resolved
src/analysis/__tests__/kpi.test.ts Show resolved Hide resolved
src/analysis/__tests__/kpi.test.ts Show resolved Hide resolved
src/analysis/__tests__/kpi.test.ts Show resolved Hide resolved
src/analysis/__tests__/kpi.test.ts Show resolved Hide resolved
@FabienRoussel FabienRoussel force-pushed the 4026_kpi_3_percent_visits_cc_contrib_on_all_visits_on_contrib_pages branch from bc00f52 to e93754e Compare May 27, 2022 17:45
@@ -1,8 +1,9215 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les dépendances sont gérés avec yarn. Il faut que tu installes yarn et pour installer les dépendances que tu lances un yarn install ou pour installer une dependance en particulier de faire un yarn install ma_dependance. Ainsi, ça va update ton yarn.lock

@FabienRoussel FabienRoussel merged commit bf63ac4 into master May 30, 2022
SocialGroovyBot added a commit that referenced this pull request May 30, 2022
# [1.13.0](v1.12.1...v1.13.0) (2022-05-30)

### Features

* KPI 3 Pourcentage de personnes qui obtiennent un résultat conventionnel dans les pages personnalisables (contributions) ([#177](#177)) ([bf63ac4](bf63ac4))
@github-actions
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants