Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(widgets visits): add new dashboard to display the monthly widgets pages visits #199

Merged
merged 9 commits into from
Mar 16, 2023

Conversation

carolineBda
Copy link
Contributor

No description provided.

@carolineBda carolineBda requested review from maxgfr and FabienRoussel and removed request for maxgfr February 15, 2023 14:37
kibana.md Outdated
@@ -0,0 +1,51 @@
# Mise à jour des rapports dans Kibana
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Du coup ça je l'avais mis directement dans le readme.md, on peut essayer de voir comment on peut merger les deux

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok j'ai supprimé et updaté le readme

@Viczei Viczei self-requested a review March 15, 2023 10:25
Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@m-maillot m-maillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top les tests! 👍
Quelques remarques sur la doc qui n'est pas très clair pour moi.

README.md Outdated
@@ -169,7 +169,14 @@ queries

## Kibana

Most analysis are indexed in ElasticSearch and visualized via Kibana Dashboards
Most analysis are indexed in ElasticSearch and visualized via Kibana Dashboards.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On pourra la mettre en fraçais également du coup :)

README.md Outdated
Most analysis are indexed in ElasticSearch and visualized via Kibana Dashboards.
Les logs sont copiés de matomo vers ES de Kibana par une [github action](https://github.com/SocialGouv/cdtn-monolog/actions/workflows/schedule.yaml) dans l'index `log-new`

Si on doit re-run les reports, il faut cleaner dans Kibana ceux déjà générés, pour ceux où on ne clean pas dans le script `runMonthly`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai pas compris cette phrase, surtout la deuxième partie concernant le script runMonthly

README.md Outdated
Si on doit re-run les reports, il faut cleaner dans Kibana ceux déjà générés, pour ceux où on ne clean pas dans le script `runMonthly`.
Par exemple ["logs-satisfaction"](./src/commands.ts).
À noter qu'il n'y a pas besoin de cleaner "log_reports" parce que le script fait un resetReportIndex juste avant de le sauver.
Pour cleaner, dans Kibana > Dev Tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus bas, on indique des commandes pour Les index à supprimer lorsqu'on relance les commandes à effectuer chaque mois. Du coup, ce n'est pas un duplicat ?

@carolineBda carolineBda merged commit ed9a4e2 into master Mar 16, 2023
@carolineBda carolineBda deleted the carolineBda/update-readme branch March 16, 2023 09:02
@github-actions
Copy link

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants