Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(azure-db): add drop-dbs command #483

Merged
merged 7 commits into from
Nov 5, 2020
Merged

feat(azure-db): add drop-dbs command #483

merged 7 commits into from
Nov 5, 2020

Conversation

revolunet
Copy link
Member

Add drop-dbs command to remove all generated dbs from a given server

douglasduteil
douglasduteil reviewed Nov 3, 2020
View reviewed changes
Copy link
Contributor

@douglasduteil douglasduteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est plus un drop autodevops databases en faite nan ?
Pareil pour les users aussi nan ?

@revolunet
Copy link
Member Author

au niveau du naming ?

drop-autodevops-dbs ?

@douglasduteil
Copy link
Contributor

drop-autodevops-dbs

Yes :)

@revolunet
Copy link
Member Author

done

@douglasduteil
Copy link
Contributor

Si t'as le time pour un ptit test https://github.com/SocialGouv/docker/blob/drop-dbs/azure-db/.gitlab-ci.yml ça serait cool sinon merge :)

@revolunet
Copy link
Member Author

là c'est un vrai test e2e sur une vraie db right ?

@douglasduteil
Copy link
Contributor

douglasduteil commented Nov 4, 2020 •
edited
Loading

là c'est un vrai test e2e sur une vraie db right ?

Ba pas forcement. Tu peux utiliser un service postgres:11.5-alpine dans le job gitlab sur lequel tu create tu tests les accès après création puis tu drop et tu test que qu'il y a plus rien

Comme le test Test azure-db 2 3 qu'on devrait peut être fragmenter ...

@revolunet
Copy link
Member Author

yep much better thanks

@revolunet
Copy link
Member Author

@douglasduteil ca teste vraiment que les bases existent plus là ? https://github.com/SocialGouv/docker/pull/483/files#diff-77a57e3aa522ccc5eca8bc500622d71ef36403ffb4d49a84e46459801b702bb1R264

@revolunet
Copy link
Member Author

yay!

@douglasduteil
Copy link
Contributor

wet ?
Il faut qu'on rajoute des \ partout ?

@revolunet
Copy link
Member Author

Je sais pas pkoi dans le script gitlab, le "negate" ! en début de ligne ne fonctionnait pas, j'ai du ajouter un pipe et dans ce cas là, oui il faut des antislashs... #WTH

@douglasduteil
Copy link
Contributor

En vrai le script est un peut lourd...
On devrait trouver un moyen de faire en sorte que ça soit moins long et plus prévisible...

@revolunet
Copy link
Member Author

quel script ? on pourra toujours améliorer :)

@revolunet revolunet merged commit 4aa1fb8 into master Nov 5, 2020
@revolunet revolunet deleted the drop-dbs branch November 5, 2020 16:46
SocialGroovyBot added a commit that referenced this pull request Nov 5, 2020
@SocialGroovyBot
chore(release): version 2.1.0
73f3b66 
# [2.1.0](v2.0.1...v2.1.0) (2020-11-05)

### Bug Fixes

* **git-deploy:** typo in /bin/create-deployment ([#485](#485)) ([52c9d25](52c9d25))

### Features

* **azure-db:** add drop-dbs command ([#483](#483)) ([4aa1fb8](4aa1fb8))
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglasduteil douglasduteil douglasduteil approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@revolunet @douglasduteil @SocialGroovyBot