gasPriceOracle Enhancement and tests #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice and siblingGasPrice
kanthgithub
force-pushed
the
feature/test-switchboard-transmitter-executor
branch
from
5cdfaff
to
6d64905
Compare
This was
linked to
issues
Feb 20, 2023
Closed
Closed
kanthgithub
requested review from
ameeshaagrawal and
arthcp
and removed request for
ameeshaagrawal
ameeshaagrawal
approved these changes
Feb 23, 2023
| @@ -63,6 +63,9 @@ export function getJsonRpcUrl(chain: keyof typeof chainIds): string { | |||
| case "arbitrum": | |||
| jsonRpcUrl = "https://arb1.arbitrum.io/rpc "; | |||
| break; | |||
| case "goerli": | |||
| jsonRpcUrl = "https://sparkling-distinguished-gadget.ethereum-goerli.discover.quiknode.pro/007d59cbcc70496817a611e740e0f84e14978636/" | |||
There was a problem hiding this comment.
please don't push private RPCs as this will be a public repo soon!
There was a problem hiding this comment.
Looks like it is not a paid rpc.
arthcp
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
view functions to get sourceGasPrice and siblingGasPrice
replace
tx.gaspriceto sourceGasPrice lookup from GasPriceOracleadd a public storage variable to store
sourceGasPricea view function to get
sourceGasPriceandrelativeGasPricefor a specific destination chainSlugtests for TransmitManager, ExecutionManager