Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SofaPython3 #51

Merged
merged 21 commits into from
Feb 14, 2022
Merged

SofaPython3 #51

merged 21 commits into from
Feb 14, 2022

Conversation

EulalieCoevoet
Copy link
Member

No description provided.

EulalieCoevoet and others added 8 commits November 13, 2020 18:06
@EulalieCoevoet
[python3] copy python directory
4e832b8
@EulalieCoevoet
[python3] createChild/createObject to addChild/addObject
9d2a73d
@EulalieCoevoet
[python3] minor cleaning
0713175
@EulalieCoevoet
[python3] easy fixes with script
75c24e2
@EulalieCoevoet
[python3] stlib/splib to stlib3/splib3
f9e8dff
@EulalieCoevoet
[python3] minor fixes
b223087
@EulalieCoevoet
[python3] some fixes:
f2d7f37 
- I could not find an example of Sofa.Prefab, did the same as VisualModel but the default value of properties does not seem to work
- I had to add STLIB to python path manually... I tried to look at the CMakeFile.txt but I have no clue of what to do
- I'm not a big fan of '.value' to access the properties...
[python3] debugging progress
0403f0e
@damienmarchal
Copy link
Member

Nice catch, tu as l'oeil ^^ (merci de regarder btw)
J'avoue avoir un pris un raccourci parce que j'etais embetee par map... Du coup tu peux peut etre m'expliquer... Pourquoi tu faisais ca? Je ne comprends toujours pas.

Je ne me souvient plus mais en regardant le code je dirais que la liste d'indice retourné par sofa était peut être au format suivant: [[1],[2],[5],[10]] et que je voulais [1,2,5,10]. Donc j'appliquait avec map un fonction lambda pour "transformer" chaque value de la liste fournie par sofa en ne prenant que la première valeur.

@EulalieCoevoet
Copy link
Member Author

@damienmarchal I think we should check and merge this PR and continue the work in this direction...

@EulalieCoevoet EulalieCoevoet changed the title [WIP] SofaPython3 SofaPython3 Jul 29, 2021
@damienmarchal
Copy link
Member

I work on it

@EulalieCoevoet
Copy link
Member Author

Thanks.

@damienmarchal
Copy link
Member

Hi,

The strategy will be the following:

  • adds in SofaPython3 the functions that were in SofaPython so old SofaPython scenes are working back, this is a general issue that is of interest for any sofa scene written in python and not only STLIB.
  • for each of these functions, adds a msg_deprecated so users have information they needs to update there scene (but it is still working)
  • restore/be sure that the feature set of STLIB/stlib and STLIB/splib are working back
  • fix the code in STLIB/stlib and STLIB/splib to remove the deprecation messages emitted
  • STLIB/stlib3 and STLIB/splib3 will be only for experiments on top of SofaPython3 and thus will be api-breaking while STLIB/stlib will not be.

Currently there are pending PR on SofaPython3 waiting to be merged for step1.

@damienmarchal
Copy link
Member

Here are the news:
SPLIB now has its own repository (so it is not more in STLIB neither in SofaPython3 (where it was integrated by mistake)). And it has a sofa-ci style test infrastructure. The repository is now located in: https://github.com/SofaDefrost/SPLIB.

Now I can work on restoring the STLIB. My first step will be to setup a working tests solutions.

@EulalieCoevoet
Copy link
Member Author

Should we merge?

@damienmarchal damienmarchal merged commit f74ce1e into master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EulalieCoevoet @damienmarchal @guparan @VannesteFelix @adagolodjo