SOFA-ROS: update example for python3 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EulalieCoevoet
changed the title
|
Hello, seems good to me ! |
|
Thanks Felix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a simple publisher/subscription example using SOFA with SofaPython plugin and ROS1 (both are based on python2).
This PR adds an example for python3 users, which require to install SofaPython3 plugin for SOFA and ROS2.
WIP:I'm new to ROS, so the migration from ROS1 to ROS2 is not straightforward for me.Although I feel like I'm almost there: ROS node and topics seem to be correctly created, the subscriptions look good as well (looking at the topics info), yet something is missing... the callback function from SOFA's subscription is never called.@akruszew are you familiar with ROS2?EDIT:
The example is working now. We found the problem with Alex.