GSoC - Adds Qserial protocol into Communication Plugin #20
Conversation
| find_package(Qt5Multimedia REQUIRED) | ||
| find_package(Qt5Widgets REQUIRED) | ||
| find_package(Qt5Gui REQUIRED) | ||
| find_package(Qt5SerialPort) |
There was a problem hiding this comment.
this one is required. But why you need gui, widget, multimedia ... ?
There was a problem hiding this comment.
Yes, others packages are not required. I will remove them in further commits.
| add_subdirectory(Communication_test) | ||
|
|
||
| IF(WIN32) | ||
| add_definitions(-D_WINSOCKAPI_) | ||
| ENDIF(WIN32) | ||
|
|
||
| add_library(${PROJECT_NAME} SHARED ${HEADER_FILES} ${SOURCE_FILES} ${EXTRA_FILES}) | ||
| target_link_libraries(${PROJECT_NAME} ${Oscpack_LIBRARIES} ${ZMQ_LIBRARIES} ${VRPN_LIBRARIES} SofaCore SofaSimulationGraph) | ||
| target_link_libraries(${PROJECT_NAME} ${Oscpack_LIBRARIES} ${ZMQ_LIBRARIES} ${VRPN_LIBRARIES} SofaCore SofaSimulationGraph Qt5::Widgets) |
There was a problem hiding this comment.
Yes, this too. I will remove it.
| #### Receive | ||
|
|
||
| ``` | ||
| <ServerCommunicationQSerial name="qserial" job="receiver" port="6000"/> |
There was a problem hiding this comment.
So, should I hardcode the port name into the code?
There was a problem hiding this comment.
what is port for serial communication ?
There was a problem hiding this comment.
Its something like /dev/ttyUSB or /dev/ttyACM
| serial->setPort(port); | ||
| serial->setBaudRate(QSerialPort::Baud9600); | ||
| serial->setDataBits(QSerialPort::Data8); | ||
| if(serial->open(QIODevice::ReadWrite)) |
There was a problem hiding this comment.
write should not be there, open once then loop on subscribers
| serial->setDataBits(QSerialPort::Data8); | ||
| if (serial->open(QIODevice::ReadOnly)) | ||
| { | ||
| serial->setDataTerminalReady(true); |
There was a problem hiding this comment.
open it only one time then loop on it.
There was a problem hiding this comment.
Can we skip this part because I will not be able to test it, even if I make suitable changes?
There was a problem hiding this comment.
you are not able to test it but it please, do the changes :)
| std::string port = d_port.getValueString(); | ||
| while(m_running) | ||
| { | ||
| serial->setPort(port); |
There was a problem hiding this comment.
port ? AFAIK no port needed :/
What is it ?
|
Don't worry. I will look at it the next week. I'm overbooked :( |
|
@ErwanDouaille No problem. It is fine. Even, I am very busy right now in college stuff. |
|
I had to revert this PR since it is unfinished work, not ready at all. |
This PR adds Qserial protocol into the communication plugin as part of GSOC project. Please review it @ErwanDouaille
This PR:
Reviewers will merge only if all these checks are true.