Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI refuses to enlarge beyond a single monitor #2889

Closed
2 tasks
tlhintoq opened this issue Nov 25, 2023 · 19 comments · Fixed by #3142 or #3149
Closed
2 tasks

UI refuses to enlarge beyond a single monitor #2889

tlhintoq opened this issue Nov 25, 2023 · 19 comments · Fixed by #3142 or #3149
Labels
bug Something isn't working

Comments

@tlhintoq
Copy link

OrcaSlicer Version

1.7

OS version

Win10x64

Additional system information

i9 gen 11
See attached specs

Printer

Any

How to reproduce

On a dual monitor PC, try to resize to take advantage of all of your screen real estate.

Actual results

Orca slicer refuses to resize taller than one monitor.

Expected results

Orca slicer shouldn't be forcing the user to a smaller space during a drag. There's already widgets in the title bar if someone want to snap to the window max.
Snag_146b753f

Project file & Debug log uploads

StealthDeck_DeviceManager

Checklist of files to include

  • Log file
  • Project file
@tlhintoq tlhintoq added the bug Something isn't working label Nov 25, 2023
@tlhintoq
Copy link
Author

Anti-bot auto-close nudge remark

@tlhintoq
Copy link
Author

tlhintoq commented Dec 3, 2023

Hey bot - Don't close me now

@tlhintoq
Copy link
Author

tlhintoq commented Dec 6, 2023

Keep alive comment

@foreachthing
Copy link

Looks like the OrcaSlicer windows' max. size is set to the startup monitor size.
Same issue on Windows 10/11.

@tlhintoq
Copy link
Author

tlhintoq commented Dec 7, 2023

@foreachthing Is that something you're looking into fixing? Or something you located and could tell @Noisyfox where it is, so it could be taken out?

@foreachthing
Copy link

@tlhintoq I'm, by all means, no programmer 😆 .
I just wanted to let you and others know that the same for Windows is happening.

@Noisyfox
Copy link
Collaborator

Noisyfox commented Dec 8, 2023

I'll take a look soon.

@Noisyfox
Copy link
Collaborator

Noisyfox commented Dec 9, 2023

I think that's a limitation of Windows, it simply does not allow you to resize a window larger than the size of your largest monitor size.

Does any of the other software you are using that allows you to do so?

@foreachthing
Copy link

foreachthing commented Dec 9, 2023

Does any of the other software you are using that allows you to do so?

Almost every other software can do that (didn't try everything I have installed, but a whole bunch). So, it's not a Windows problem. It's the application not allowing to be larger than a single monitor.
Need more info, please let me know.

Edit: even PrusaSlicer can extend over more than one monitor.

@tlhintoq
Copy link
Author

tlhintoq commented Dec 9, 2023

Does any of the other software you are using that allows you to do so?

Absolutely - nearly any program should do it so long as there hasn't been some specific action taken by a program to deliberately stop it.
Its a pretty common case - Aren't you running Visual Studio? It does it. Pretty common to run code on a vertical monitor or on two monitors acting as one.
Snag_f4bd9a4
Snag_f4bfcdb
Snag_f4c197c
Snag_f4c2ab2

@tlhintoq
Copy link
Author

Keep alive

@Noisyfox
Copy link
Collaborator

I've found the cause of this issue. Will raise a PR soon.

Noisyfox added a commit to Noisyfox/OrcaSlicer that referenced this issue Dec 16, 2023
@Noisyfox Noisyfox linked a pull request Dec 16, 2023 that will close this issue
@Noisyfox
Copy link
Collaborator

Noisyfox commented Dec 16, 2023

Could you give the pr build a try and see if it solves the problem? @tlhintoq @foreachthing

@Noisyfox
Copy link
Collaborator

There are a few bugs found. Repoening this.

@Noisyfox Noisyfox reopened this Dec 16, 2023
@tlhintoq
Copy link
Author

Watching for updates.
Sidenote: I haven't run Visual Studio in a couple years. I don't even have it installed on my new laptop. So pulling and compiling won't happen right away for me. {But I'm realizing I probably need to get back into this side of things}

SoftFever added a commit that referenced this issue Dec 17, 2023
Noisyfox added a commit to Noisyfox/OrcaSlicer that referenced this issue Dec 17, 2023
@Noisyfox Noisyfox linked a pull request Dec 17, 2023 that will close this issue
@Noisyfox
Copy link
Collaborator

Sidenote: I haven't run Visual Studio in a couple years. I don't even have it installed on my new laptop. So pulling and compiling won't happen right away for me.

You don't have to do this. We got CI build for every PRs, so you could just download the binary from it.

@foreachthing
Copy link

@Noisyfox, which one should I try? https://github.com/SoftFever/OrcaSlicer/actions
Thanks!!

@Noisyfox
Copy link
Collaborator

https://github.com/SoftFever/OrcaSlicer/actions/runs/7235901104?pr=3149
this one

@foreachthing
Copy link

This PR works for me 😁
This screenshot spans over 2x 4k monitors. It's an AWESOME sight! 👍🏼

image

SoftFever added a commit that referenced this issue Dec 20, 2023
Do not limit the max window size (#2889)

Co-authored-by: SoftFever <softfeverever@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants