Port single wall on top surface from classic wall generator to Arachne #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smart 👍 |
SoftFever
reviewed
Jul 25, 2023
|
@Noisyfox
|
…ween classic and Arachne. This also adds bridge detection to Arachne as well.
Noisyfox
force-pushed
the
dev/arachne_top_wall
branch
from
db31b49
to
2e551b8
Compare
Noisyfox
force-pushed
the
dev/arachne_top_wall
branch
from
70e9837
to
166552b
Compare
|
Just noticed the inset between the infill and wall is incorrect. Will try fixing it tomorrow. |
|
Should be good now. |
# Conflicts: # src/libslic3r/PerimeterGenerator.cpp
SoftFever
approved these changes
Jul 29, 2023
|
Look good to me. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very naive porting of the algorithm attempt to fix issue #582 #1538 #1560. The idea is to run the Arachne wall generator twice, one with only 1 wall loop to generate the out shell, then run it again only for the non-top area with wall loop - 1, then combine both paths together to achieve the "only 1 wall on top surface", without changing the Arachne generator itself.
Extensive tests needed to ensure the print quality with such layer split-combine process.