Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix de new feature #4479

Merged
merged 1 commit into from Mar 14, 2024
Merged

fix de new feature #4479

merged 1 commit into from Mar 14, 2024

Conversation

hliebscher
Copy link
Contributor

No description provided.

discip
discip suggested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@discip discip left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure you didn't mean to translate Scarf Joint as Schaltnaht.

It should be something like Schäftung.

https://de.wikipedia.org/wiki/Sch%C3%A4ften

plexi32
plexi32 suggested changes Mar 14, 2024
View reviewed changes
localization/i18n/de/OrcaSlicer_de.po

msgid "This factor affects the amount of material for scarf joints."
msgstr ""
msgstr "Dieser Faktor beeinflusst die Menge an Material für Schaltnähte."

msgid "Scarf start height"
msgstr "Start Höhe des Schalnaht"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besser wäre: Start-Höhe

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schaltnaht kommt öfter fälschlicherweise vor.

localization/i18n/de/OrcaSlicer_de.po

msgid "This factor affects the amount of material for scarf joints."
msgstr ""
msgstr "Dieser Faktor beeinflusst die Menge an Material für Schaltnähte."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tippfehler: Schalnähte

localization/i18n/de/OrcaSlicer_de.po

msgid "Scarf joint flow ratio"
msgstr ""
msgstr "Schaltnaht Flussverhältnis"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schalnaht

@discip
Copy link
Contributor

discip commented Mar 14, 2024

@plexi32
In German there is no such term like Schalnaht.

As mentioned above, the name for this kind of junction is either Schäftung or Schäftverbindung.

@SoftFever
Copy link
Owner

Thanks all for the feedback 👍
Unfortunately I can't give opinions on it.
Feel free to discuss it in Discord and submit PRs.

SoftFever
SoftFever approved these changes Mar 14, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SoftFever SoftFever merged commit 401af40 into SoftFever:main Mar 14, 2024
1 check passed
@hliebscher hliebscher deleted the de-for-2.0-beta branch March 23, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discip discip discip requested changes

@plexi32 plexi32 plexi32 requested changes

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hliebscher @discip @SoftFever @plexi32