The contest's buttons are no longer disabled when an admin changes the contest's password. #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the contest's buttons for compete / practice were disabled when an administrator changed the contest's password, because we were checking whether the user is currently active, which means that he should not be invalidated. But when the passwords are changed, the user is invalidated. The buttons should not be active only when the user's compete / participation time has ran out. This way if an admin changes the password while the user is participating / competing in the contest, they will be required to provide the new password and the buttons will not be disabled.
…est's new password.
…the-competepractice-buttons-and-the-access-to-the-contest
gogo4ds
requested changes
Jun 20, 2024
Services/UI/OJS.Services.Ui.Models/Contests/ContestParticipationServiceModel.cs
Show resolved
Hide resolved
gogo4ds
approved these changes
Jun 21, 2024
deyordanov
deleted the
1359-contest-passwords-deactivate-the-competepractice-buttons-and-the-access-to-the-contest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1359