Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of 'Notification' and 'Bluetooth' permissions #519

Merged
merged 9 commits into from
Mar 2, 2023

Conversation

nkrisko
Copy link
Contributor

@nkrisko nkrisko commented Feb 27, 2023

Description

Added check and request for custom permissions of 'Notification' and 'Bluetooth' types

Issues Resolved

API Changes

Added:

  • NuGet - System.Reactive to :

    • Softeq.XToolkit.Permissions.iOS
  • Softeq.XToolkit.Permissions/PermissionsService.cs

Removed:

  • Softeq.XToolkit.Permissions.iOS/PermissionsService.cs
  • Softeq.XToolkit.Permissions.Droid/PermissionsService.cs

Platforms Affected

  • Core (all platforms)
  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code styles
  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

# Conflicts:
#	Softeq.XToolkit.Permissions.Droid/Softeq.XToolkit.Permissions.Droid.csproj
#	Softeq.XToolkit.Permissions.iOS/Softeq.XToolkit.Permissions.iOS.csproj
#	samples/Playground/Playground.Droid/Playground.Droid.csproj
#	samples/Playground/Playground.Droid/Properties/AndroidManifest.xml
#	samples/Playground/Playground.iOS/Info.plist
#	samples/Playground/Playground.iOS/Playground.iOS.csproj
# Conflicts:
#	Softeq.XToolkit.Permissions.Droid/PermissionsManager.cs
#	Softeq.XToolkit.Permissions.iOS/PermissionsManager.cs
#	Softeq.XToolkit.Permissions.iOS/PermissionsService.cs
#	Softeq.XToolkit.Permissions.iOS/Softeq.XToolkit.Permissions.iOS.csproj
#	Softeq.XToolkit.Permissions/NotificationsPermission.cs
#	samples/Playground/Playground/ViewModels/Components/PermissionsPageViewModel.cs
# Conflicts:
#	samples/Playground/Playground.Droid/Views/Components/PermissionsPageActivity.cs
@github-actions github-actions bot added c/permissions Related to Permissions component. c/playground Related to Playground samples. p/Android Related to Android platform. p/iOS Related to iOS platform. labels Feb 27, 2023
@wcoder wcoder added this to the vNext milestone Mar 1, 2023
@wcoder
Copy link
Contributor

wcoder commented Mar 1, 2023

From CI logs:

##[error]The job running on agent Hosted Agent ran longer than the maximum time of 60 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134

@wcoder wcoder merged commit a4cb501 into master Mar 2, 2023
@wcoder wcoder deleted the feature/expanded-permissions branch March 2, 2023 14:39
pavel-leonenko added a commit that referenced this pull request Mar 27, 2024
* Update documentation & CI (#501)

* Simplify projects to SDK style (#498)

* Migrate to .NET6+ (#513)

* Migrate from Xamarin.Essentials to Microsoft.Maui.Essentials (#517)

* Update documentation & rework nested namespaces (#514)

* Resolve warnings (#515)

* Implementation of 'Notification' and 'Bluetooth'  permissions (#519)

Co-authored-by: Yauheni Pakala <evgeniy.pakalo@gmail.com>

* Add System.Text.Json serializer and tests (#521)

* Show warning when ConfigureAwait should be used (#522)

* Remove Chunkify method (#523)

* Remove Newtonsoft.Json (#524)

* Update CI environment (#530)

* Migrate Common.iOS & Common.Droid Tests to .NET6 (#525)

* Replace Connectivity plugin to MAUI Essentials (#531)

* location eq added

* comment fixed

* Refactor permissions library (#535)

* Add binding support for Count property (ObservableKeyGroupsCollection) (#538)

* Update docfx (#534)

* Improvements before migration to .NET8 (#539)

* Add supported os versions

* Bump year

* Update target framework for nuspecs

* Sync wl.essentials platform target frameworks

* Add install missed android sdk for api 32

* Bump android target api

* Revert "Add install missed android sdk for api 32"

This reverts commit a89a7c4.

* Migrate to .NET8 (#536)

* Bump dotnet version

* Bump target framework to .net8

* Migrate Microsoft.Maui.Essentials to use as explicit NuGet packages

* Remove obsoleted binary serialization for BiDictionary

* Cleanup

* Migrate Maui to use as explicit NuGet package

* Sync target frameworks and min supported os

* Use the same MAUI version in all projects

* Bump .NET8 to stable

* Update pipelines env

* Bump iOS target framework for latest maui & essentials

* Resolve warnings related to supported versions

* Update nuget package

* Sync versions

* add extensions

* make permission method virtual

* remove unused property

* add methods to icontainerbuilder

* Feature/minor fixes (#545)

* Updated copyright

* Fixed binding to ObservableRangeCollection.Count when calling RemoveRange (#544)

* Removed excess AndroidResource tags

* Restored mistakenly deleted PropertyGroup

* Fixed copyright

* rename methods

---------

Co-authored-by: Pavel Leonenko <pleonenko@halocollar.com>
Co-authored-by: s.leushunou <siarhei.leushunou@softeq.com>

---------

Co-authored-by: Yauheni Pakala <evgeniy.pakalo@gmail.com>
Co-authored-by: nkrisko <50995914+nkrisko@users.noreply.github.com>
Co-authored-by: Kirill Akulich <kirill.akulich@softeq.com>
Co-authored-by: Pavel Leonenko <1992leon@bk.ru>
Co-authored-by: Pavel Leonenko <pleonenko@halocollar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/permissions Related to Permissions component. c/playground Related to Playground samples. p/Android Related to Android platform. p/iOS Related to iOS platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android 11+ invalid runtime permissions handling for "ask again later" answer
2 participants