Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements before migration to .NET8 #539

Merged
merged 7 commits into from Dec 20, 2023
Merged

Improvements before migration to .NET8 #539

merged 7 commits into from Dec 20, 2023

Conversation

wcoder
Copy link
Contributor

@wcoder wcoder commented Dec 15, 2023

Description

  • Add SupportedOSPlatformVersion for packages
  • Update nuspecs
  • Sync target frameworks

API Changes

None

Platforms Affected

  • Core (all platforms)
  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code styles
  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@github-actions github-actions bot added c/common Related to Common component. c/bindings Related to Bindings component. c/wl Related to WhiteLabel component. c/connectivity Related to Connectivity component. c/push-notifications Related to Push Notifications component. p/Android Related to Android platform. p/iOS Related to iOS platform. c/permissions Related to Permissions component. c/wl.essentials Related to WhiteLabel.Essentials component. labels Dec 15, 2023
@wcoder wcoder mentioned this pull request Dec 15, 2023
Merged
6 tasks
@github-actions github-actions bot added the CI/CD Related to CI/CD. label Dec 15, 2023
@github-actions github-actions bot removed the CI/CD Related to CI/CD. label Dec 16, 2023
@wcoder wcoder added this to the vNext milestone Dec 16, 2023
@wcoder
Copy link
Contributor Author

wcoder commented Dec 19, 2023

@dimysa you are right about old dependencies in nuspecs but currently, it's out of the scope of this PR
Could you please check again?

@dimysa
Copy link
Contributor

dimysa commented Dec 20, 2023

@dimysa you are right about old dependencies in nuspecs but currently, it's out of the scope of this PR Could you please check again?

The PR description says to update nuspecs, so it seems strange to me that this is out of scope. Maybe I'm wrong, but we can't use this nuspec to create nugets now.
But if you say it's out of scope, I assume it will be fully changed in the future?

dimysa
dimysa approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@dimysa dimysa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the changes look clear, but there are questions about nuspecs

nuget/Softeq.XToolkit.Permissions.nuspec
<tags>softeq, xtoolkit, xamarin, ios, android, permissions</tags>
<releaseNotes/>
<dependencies>
<group targetFramework="netstandard2.1">
<group targetFramework="net6.0">
<dependency id="Xamarin.Essentials" version="1.7.3" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There don't seem to be any dependencies on Xamarin.Essentials anymore

@wcoder wcoder merged commit 84e4ef3 into master Dec 20, 2023
3 checks passed
@wcoder
Copy link
Contributor Author

wcoder commented Dec 20, 2023 •
edited

But if you say it's out of scope, I assume it will be fully changed in the future?

Yes you are right, nuspecs approach will be reworked in the future

pavel-leonenko added a commit that referenced this pull request Mar 27, 2024
@sleushunou @wcoder
@nkrisko @pavel-leonenko
Update ph1 to net8 (#542)
acd47d9 
* Update documentation & CI (#501)

* Simplify projects to SDK style (#498)

* Migrate to .NET6+ (#513)

* Migrate from Xamarin.Essentials to Microsoft.Maui.Essentials (#517)

* Update documentation & rework nested namespaces (#514)

* Resolve warnings (#515)

* Implementation of 'Notification' and 'Bluetooth'  permissions (#519)

Co-authored-by: Yauheni Pakala <evgeniy.pakalo@gmail.com>

* Add System.Text.Json serializer and tests (#521)

* Show warning when ConfigureAwait should be used (#522)

* Remove Chunkify method (#523)

* Remove Newtonsoft.Json (#524)

* Update CI environment (#530)

* Migrate Common.iOS & Common.Droid Tests to .NET6 (#525)

* Replace Connectivity plugin to MAUI Essentials (#531)

* location eq added

* comment fixed

* Refactor permissions library (#535)

* Add binding support for Count property (ObservableKeyGroupsCollection) (#538)

* Update docfx (#534)

* Improvements before migration to .NET8 (#539)

* Add supported os versions

* Bump year

* Update target framework for nuspecs

* Sync wl.essentials platform target frameworks

* Add install missed android sdk for api 32

* Bump android target api

* Revert "Add install missed android sdk for api 32"

This reverts commit a89a7c4.

* Migrate to .NET8 (#536)

* Bump dotnet version

* Bump target framework to .net8

* Migrate Microsoft.Maui.Essentials to use as explicit NuGet packages

* Remove obsoleted binary serialization for BiDictionary

* Cleanup

* Migrate Maui to use as explicit NuGet package

* Sync target frameworks and min supported os

* Use the same MAUI version in all projects

* Bump .NET8 to stable

* Update pipelines env

* Bump iOS target framework for latest maui & essentials

* Resolve warnings related to supported versions

* Update nuget package

* Sync versions

* add extensions

* make permission method virtual

* remove unused property

* add methods to icontainerbuilder

* Feature/minor fixes (#545)

* Updated copyright

* Fixed binding to ObservableRangeCollection.Count when calling RemoveRange (#544)

* Removed excess AndroidResource tags

* Restored mistakenly deleted PropertyGroup

* Fixed copyright

* rename methods

---------

Co-authored-by: Pavel Leonenko <pleonenko@halocollar.com>
Co-authored-by: s.leushunou <siarhei.leushunou@softeq.com>

---------

Co-authored-by: Yauheni Pakala <evgeniy.pakalo@gmail.com>
Co-authored-by: nkrisko <50995914+nkrisko@users.noreply.github.com>
Co-authored-by: Kirill Akulich <kirill.akulich@softeq.com>
Co-authored-by: Pavel Leonenko <1992leon@bk.ru>
Co-authored-by: Pavel Leonenko <pleonenko@halocollar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimysa dimysa dimysa approved these changes

@pavel-leonenko pavel-leonenko Awaiting requested review from pavel-leonenko

@sleushunou sleushunou Awaiting requested review from sleushunou

@TimofeyBurak TimofeyBurak Awaiting requested review from TimofeyBurak

@nkrisko nkrisko Awaiting requested review from nkrisko

Assignees
No one assigned
Labels
c/bindings Related to Bindings component. c/common Related to Common component. c/connectivity Related to Connectivity component. c/permissions Related to Permissions component. c/push-notifications Related to Push Notifications component. c/wl.essentials Related to WhiteLabel.Essentials component. c/wl Related to WhiteLabel component. p/Android Related to Android platform. p/iOS Related to iOS platform.
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wcoder @dimysa