-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of Python microservice example #2199
Conversation
Preview available here |
I added @jochenendres and @mgrumann from the responsible team, but regarding Python I have no clue. |
Added logging so that some output can be seen in the Admin app, bumped to recent manifest version, advertised automated authentication.
Thanks ... @jochenendres @mgrumann Feel free to nominate someone else. I noticed a little cosmetic issue, not sure if that would be a one liner fix or more involved: The microservice proxies reports authentication errors differently from the normal REST endpoints. You get an "internalError" reported, which shouldn't be the case if you just leave out the credentials ... |
Co-authored-by: BeateRixen <90445236+BeateRixen@users.noreply.github.com>
Co-authored-by: BeateRixen <90445236+BeateRixen@users.noreply.github.com>
Co-authored-by: BeateRixen <90445236+BeateRixen@users.noreply.github.com>
|
||
* Is a multi-tenant microservice, which means that it runs only once even if many customers are subscribed to it. | ||
* Has two replicas as required for highly available production microservices. Note: For development purposes where high availability is not required, you can set this to one replica only. | ||
* Has so-called liveness and readiness probes that {{< product-c8y-iot >}} uses to check if your microservice is healthy and can run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding: with this framework , should the customer implement the /health endpoint? If yes, maybe a hint mentioning it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I merged the PR already before your comment. I updated the text, but the change will only go into the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I have not noticed that it has been merged :) probably it was done while I was reviewing it.
I took the liberty and rewrote the text a little. My main goals are:
I'll still create PRs for the cumulocity-examples and c8y_microservice-python.
@BeateRixen Do you happen to know who the SME for reviewing this could be?