This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
#121: Implement the UI to connect manage the certificate of the PKI #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added Button-OperationService-certificateService
dirk-peter-c8y
suggested changes
Jun 10, 2022
...n-fe/src/modules/pki-managed-certificates/create-certificate/create-certificate.component.ts
Outdated
Show resolved
Hide resolved
pkiintergration-fe/src/modules/pki-managed-certificates/pki-managed-certificates.component.html
Outdated
Show resolved
Hide resolved
pkiintergration-fe/src/modules/pki-managed-certificates/pki-managed-certificates.component.ts
Outdated
Show resolved
Hide resolved
pkiintergration-fe/src/modules/pki-managed-certificates/pki-managed-certificates.component.ts
Outdated
Show resolved
Hide resolved
pkiintergration-fe/src/modules/pki-managed-certificates/pki-managed-certificates.component.ts
Outdated
Show resolved
Hide resolved
pkiintergration-fe/src/modules/pki-managed-certificates/pki-managed-certificates.component.ts
Outdated
Show resolved
Hide resolved
…Adjusted after Code Review/ Added Button to Create Keypair/ Added Service with DevicedId
dirk-peter-c8y
suggested changes
Jun 21, 2022
…Added Admin Applikation/ Code adjusted after Code Review/ Fixed error in MicroService
dirk-peter-c8y
suggested changes
Jul 4, 2022
| @@ -1 +1 @@ | |||
| <button id="action-btn" class="btn-link" type="button" (click)="requestPubKey()">Create Keypair</button> | |||
| <button id="action-btn" class="btn-link" type="button" style="text-align: left;" (click)="requestPubKey()">Set device connection method</button> | |||
Comment on lines
12
to
24
| // device: IManagedObject; | ||
| alertService: AlertService; | ||
| ActivatedRoute: ActivatedRoute; | ||
|
|
||
| constructor(private keypairService: CreateKeyPairService, private route: ActivatedRoute) {} | ||
| constructor(private createKeypairService: CreateKeyPairService, private activatedRoute: ActivatedRoute) {} | ||
|
|
||
| ngOnInit() { | ||
| const snapshot = this.route.snapshot; | ||
| const snapshot = this.activatedRoute.snapshot; | ||
| if (snapshot && snapshot.firstChild && snapshot.firstChild.data) { | ||
| this.deviceId = snapshot.firstChild.data.contextData.id; | ||
| } | ||
|
|
||
| console.log('devideid:', this.deviceId); |
There was a problem hiding this comment.
todo: mark page as "work in progress" or resolve previously mentioned issues
Comment on lines
29
to
30
| <button class="btn btn-default" translate="" (click)="bsModalRef.hide()">Cancel</button> | ||
| <button type="submit" class="btn btn-primary" (click)="bsModalRef.hide()">Generate</button> |
There was a problem hiding this comment.
question: why do both buttons trigger the same action/function - where is the difference?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tab Managed Certificates and Button