Merge pull request #542 from SoftwareBrothers/fix/452-populate-edit-a…

…ction fix: populate record after editfixes #452
SoftwareBrothers · Aug 7, 2020 · 9b126d3 · 9b126d3
2 parents 411698a + 0ce3e63
commit 9b126d3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/example-app/cypress.env.json b/example-app/cypress.env.json
@@ -1,5 +1,5 @@
 {
-  "MONGO_URL": "mongodb://localhost:27017/e2e",
+  "MONGO_URL": "mongodb://localhost:27017/e2e2",
   "ADMIN_EMAIL": "admin@example.com",
   "ADMIN_PASSWORD": "password",
   "ADMIN_COMPANY": "default company",

diff --git a/src/backend/actions/edit-action.ts b/src/backend/actions/edit-action.ts
@@ -1,5 +1,6 @@
 import Action, { RecordActionResponse } from './action.interface'
 import NotFoundError from '../utils/not-found-error'
+import populator from '../utils/populator'
 
 /**
  * @implements Action
@@ -38,18 +39,20 @@ const EditAction: Action<RecordActionResponse> = {
       return { record: record.toJSON(currentAdmin) }
     }
     await record.update(request.payload)
+    const [populatedRecord] = await populator([record])
+
     if (record.isValid()) {
       return {
         redirectUrl: h.resourceUrl({ resourceId: resource._decorated?.id() || resource.id() }),
         notice: {
           message: translateMessage('successfullyUpdated', resource.id()),
           type: 'success',
         },
-        record: record.toJSON(currentAdmin),
+        record: populatedRecord.toJSON(currentAdmin),
       }
     }
     return {
-      record: record.toJSON(currentAdmin),
+      record: populatedRecord.toJSON(currentAdmin),
       notice: {
         message: translateMessage('thereWereValidationErrors'),
         type: 'error',

diff --git a/src/backend/decorators/action-decorator.spec.ts b/src/backend/decorators/action-decorator.spec.ts
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/explicit-function-return-type */
 import { expect } from 'chai'
 import sinon from 'sinon'
 import ActionDecorator from './action-decorator'