Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change a-player preload to none #37

Merged

Conversation

joshmorel
Copy link
Contributor

Resolves issue #32

@jasonify - Try this out and see if it resolves the issue. If you want mp3s preloaded in ItemView.vue but not the list Views we'll need additional logic but I'm not sure if we (or the users) would want that.

@jasonify
Copy link
Collaborator

jasonify commented Oct 20, 2017

Thanks a lot for looking into this :).

Take a look here though, since we are moving to a system to use one global player:

https://github.com/SoftwareEngineeringDaily/sedaily-front-end/tree/global-player-WIP

Further cleaned up UI (but includes a lot more modifications for selenium integration):
https://github.com/SoftwareEngineeringDaily/sedaily-front-end/tree/testing-setup

We were having problems with the third party library so I modified it. I will need to look into this further but the quick changes seem to fix the problems with loading different mp3s on demand.

Maybe you have a better idea? At one point I should submit a PR to that project directly.

I apologize, we should be merging our branches much sooner.

@jasonify jasonify merged commit 5184eea into SoftwareEngineeringDaily:master Oct 20, 2017
@joshmorel
Copy link
Contributor Author

I see this now - makes a lot more sense to have a global player! I'll start getting more familiar with the entire code base and dependencies and then hopefully have further ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants