Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EKS CNI configuration from manual step to add-on #23

Merged
merged 3 commits into from Nov 21, 2023

Conversation

lumberbaron
Copy link
Collaborator

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently, the step to configure the WARM_IP_TARGET and WARM_ENI_TARGET configuration of the EKS's CNI has been done as a manual step, specifically editing of the DaemonSet. The CNI add-on supports configuring these using the 'additional configuration' option. Updated the Terraform to configure it that way, and updated the readme to remove the manual step and instead describe the changes we're making automatically.

This also updates some Terraform providers to the latest, including updating the GKE project to stop to move to the regular google provider completely.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link
Contributor

@hadielaham88 hadielaham88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumberbaron lumberbaron merged commit 10504de into SolaceLabs:main Nov 21, 2023
3 checks passed
@lumberbaron lumberbaron deleted the eks-addon-cni-params branch November 21, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants