Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not be build localy with java 11 #38

Closed
GreenRover opened this issue Dec 18, 2020 · 1 comment · Fixed by #39
Closed

Can not be build localy with java 11 #38

GreenRover opened this issue Dec 18, 2020 · 1 comment · Fixed by #39
Labels
bug Something isn't working
Milestone

Comments

@GreenRover
Copy link
Contributor

when i do:

git clone https://github.com/SolaceProducts/solace-spring-cloud.git
cd solace-spring-cloud
mvn package

i run into:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar (attach-javadocs) on project solace-spring-cloud-connector: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR]
[ERROR] Command line was: C:\devsbb\java\jdk-11.0.7\bin\javadoc.exe @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in 'C:\devsbb\git\solace-spring-cloud\solace-spring-cloud-connector\target\apidocs' dir.
[ERROR]

This is a known error with java > 1.8 (tested openjdk 11 and 14)

After fixing this i run into

Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.2.0:jar (default-jar) on project spring-cloud-starter-stream-solace: You have to use a classifier to attach supplemental artifacts to the project instead of replacing them. -> [Help 1]
@Nephery Nephery added the bug Something isn't working label Dec 21, 2020
@Nephery Nephery linked a pull request Jan 15, 2021 that will close this issue
@Nephery Nephery mentioned this issue Feb 24, 2021
Nephery added a commit that referenced this issue Feb 24, 2021
### Global
* Major version bump to `2.0.0`
* Upgrade to `spring-cloud` `2020.0.1`
* Upgrade to `spring-boot` `2.4.3`
* Upgrade to `sol-jcsmp` `10.10.0`
* Upgrade to `sol-jms` `10.10.0`
* Fix Java 11 build (#38)
* Migrate CI from Travis to Github Actions
* Use Maven Failsafe plugin to run integration tests

### Solace Spring Cloud Stream Binder
* Major version bump to `3.0.0`
* Add Solace Spring Message Headers (#50)
  * Add `SolaceHeaders` and `SolaceBinderHeaders`
  * Bidirectionally map `SolaceHeaders` to JCSMP properties so message handlers can read/write Solace properties
* Renamed "Binder DMQ" to "Error Queue"
* Fix requeuing logic (#13)
  * requeuing is no longer supported for anonymous consumer groups (i.e. temporary queues) since these cannot be rebound.
* Add support for manual acknowledgments (#14)
* Removed the message discard error handling strategy from defined consumer groups. The new default for these will be requeuing.
* Add support for wildcard destinations (#3)
* add consumer config options to omit group name from the consumer group queue or error queue names (#28)
* add `errorQueueNameOverride` consumer config option to override the generated error queue name with a custom config-provided one. (#28)
* Add `headerExclusions` producer config option to exclude headers from published messages
* Add `nonserializableHeaderConvertToString ` producer config option to convert non-serializable headers to strings
* Override the default DMQ eligibility when publishing to be true (#9)
* Remove `solace_raw_message` error-channel message header in favor of `sourceData` header
* Fix JMS interoperability
* Fix `null` payload error handling (#54)
* Fix error handling failures (#36)
* Add `errorMsgDmqEligibility` consumer config option to override failed input messages' DMQ eligibility property when republishing to error queues
* Refactor default generated queue names to be more similar to Solace's shared subscriptions feature
* Fix asynchronous publishing exceptions to be sent to error channels (#34)
* Properly construct the `ErrorMessage` for publisher failures
* Configure client info provider to display Solace SCSt Binder release details
* Reduce warning levels from WARN to INFO when provisioning is disabled or when subscriptions already exist on queues
* Document ACL Profile tips when using error queues (#60)

### Solace Spring Cloud Connector
* Upgrade to `spring-cloud-connectors` `2.2.13.RELEASE` (version managed separately from spring cloud BOM)
@Nephery
Copy link
Collaborator

Nephery commented Feb 25, 2021

Closed with #75

@Nephery Nephery closed this as completed Feb 25, 2021
@Nephery Nephery added this to the SCSt 3.0.0 milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants