-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new vote #30
Conversation
Thank you everyone for your feedback. @sleepdefic1t please have a look at my latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made these additional checks in the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The final vote % must be 100%.
Please add an additional check, and test case, to enforce that values less than 100% are also rejected.
Example usage:
In a separate PR I'll bump the lib version add create CHANGELOG file to track changes for each release.