Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 2.2.5 into 2.3.x #933

Merged
merged 91 commits into from
Nov 2, 2023
Merged

Conversation

pierredup
Copy link
Member

Release Notes for 2.2.5

2.2.5

  • Total issues resolved: 0
  • Total pull requests resolved: 1
  • Total contributors: 1

bug

The currency is set when creating an initial company, so it's not
necessary to set it during installaition.
* origin/currency-fixes:
  Fix CS
  Fix cases where currency might be empty
  Check if app is installed before including scripts
  Remove debug code
  Fix currency handling
….x-merge-up-into-2.3.x_W6EQPTxa

* '2.3.x' of github.com:SolidInvoice/SolidInvoice: (171 commits)
  Bump sass-loader from 13.3.0 to 13.3.2
  Bump semver from 5.7.1 to 5.7.2
  Bump cloudinary from 1.37.1 to 1.40.0
  Bump step-security/harden-runner from 2.4.0 to 2.5.1
  Add Sentry as a sponsor
  Bump eslint from 8.42.0 to 8.48.0
  Bump JetBrains/qodana-action from 2023.1.0 to 2023.2.1
  Bump actions/checkout from 3.5.3 to 3.6.0
  Bump docker/setup-buildx-action from 2.6.0 to 2.9.1
  Bump word-wrap from 1.2.3 to 1.2.4
  Bump intl-messageformat from 10.3.5 to 10.5.0
  Bump @babel/cli from 7.21.5 to 7.22.5
  Bump stylelint-scss from 5.0.0 to 5.0.1
  Bump @babel/eslint-parser from 7.21.8 to 7.22.5
  Bump jquery from 3.6.4 to 3.7.0
  Bump actions/checkout from 3.5.2 to 3.5.3
  Bump docker/setup-buildx-action from 2.5.0 to 2.6.0
  Bump webpack-cli from 5.1.3 to 5.1.4
  Bump cloudinary from 1.37.0 to 1.37.1
  Bump sass from 1.62.1 to 1.63.3
  ...
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (558daa1) 50.51% compared to head (8501546) 50.97%.
Report is 98 commits behind head on 2.3.x.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.3.x     #933      +/-   ##
============================================
+ Coverage     50.51%   50.97%   +0.46%     
- Complexity     2208     2213       +5     
============================================
  Files           437      442       +5     
  Lines          8241     8137     -104     
============================================
- Hits           4163     4148      -15     
+ Misses         4078     3989      -89     
Flag Coverage Δ
unittests 50.97% <54.25%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/ApiBundle/ApiTokenManager.php 100.00% <100.00%> (ø)
...e/DependencyInjection/SolidInvoiceApiExtension.php 100.00% <100.00%> (ø)
...ApiBundle/Event/Listener/InvoiceCreateListener.php 100.00% <100.00%> (ø)
...c/ApiBundle/Event/Listener/QuoteCreateListener.php 100.00% <100.00%> (ø)
src/ApiBundle/Security/ApiTokenAuthenticator.php 66.66% <ø> (-2.39%) ⬇️
...iBundle/Security/Provider/ApiTokenUserProvider.php 61.53% <100.00%> (-2.75%) ⬇️
.../Normalizer/AdditionalContactDetailsNormalizer.php 94.44% <100.00%> (-0.30%) ⬇️
...iBundle/Serializer/Normalizer/CreditNormalizer.php 91.66% <100.00%> (ø)
...piBundle/Serializer/Normalizer/MoneyNormalizer.php 100.00% <100.00%> (ø)
...rc/ClientBundle/Entity/AdditionalContactDetail.php 52.63% <ø> (ø)
... and 89 more

... and 176 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierredup pierredup merged commit 8501546 into 2.3.x Nov 2, 2023
19 checks passed
@pierredup pierredup deleted the 2.2.x-merge-up-into-2.3.x_W6EQPTxa branch November 2, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants