Add formatted output generation on top of BufferWriter. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSUdaemon
reviewed
Mar 1, 2018
lib/ts/bwprint.cc
Outdated
| prefix = "0B"_sv; | ||
| n = detail::bwf_to_radix<2>(i, buff, sizeof(buff), detail::UPPER_DIGITS); | ||
| break; | ||
| break; |
There was a problem hiding this comment.
Dang, I thought I'd fixed that.
PSUdaemon
reviewed
Mar 1, 2018
lib/ts/bwprint.cc
Outdated
| case 'x': | ||
| if (spec._radix_lead_p) | ||
| prefix = "0x"_sv; | ||
| n = detail::bwf_to_radix<16>(i, buff, sizeof(buff), detail::LOWER_DIGITS); |
There was a problem hiding this comment.
Putting braces around the body of the if will fix this weird formatting and also match our style guide.
There was a problem hiding this comment.
Haha, yeah, that's some serious ugly there, isn't it?
ywkaras
reviewed
Mar 1, 2018
lib/ts/bwprint.cc
Outdated
| if (!sz) | ||
| return; | ||
| } else { | ||
| throw std::invalid_argument("Precision mark without precision"); |
There was a problem hiding this comment.
Generic use of exceptions is questionable in a source base that has not be upgraded to exception safety.
ywkaras
reviewed
Mar 1, 2018
lib/ts/bwprint.cc
Outdated
|
|
||
| ts::BWFormat::~BWFormat() | ||
| { | ||
| } |
|
I really don't like the duplication between |
Now the log-headers request will propagate upstream even when logging is not enabled on the local box. This makes it easier to use on higher tier caches. Also added documentation.
The same element is fetched in test one and 5. On a loaded system it could be in cache for a second and report age:1 instead of age:0
This is a bug introduced with PR apache#2335. The `if` is to avoid unnecessary works when buffering the post body, but since redirects also need to execute the logic flow and the request info may be changed during the process of redirects. We need to extract the request info every time redirects happen.
SolidWallOfCode
force-pushed
the
bwprint
branch
from
b2f3929
to
86b6cee
Compare
Change 'const std::string &' parameters to virtual member functions of the TranformationPlugin class to ts::string_view. This allows derived classes of TranformationPlugin to avoid using std::string in some cases, resulting in less copying and dynamic memory allocation.
SolidWallOfCode
force-pushed
the
bwprint
branch
from
ad9d2f5
to
82fc0f9
Compare
SolidWallOfCode
pushed a commit
that referenced
this pull request
Sep 7, 2019
Do not require lhiredis on all binaries when building ssl_session_reuse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.