Improvements to lifting 11k #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scaleAnalytes() now skips missing references
stufield
force-pushed
the
improvements-to-lifting-11k
branch
from
5c49e3f
to
1d72db6
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 73.88% 75.23% +1.35%
==========================================
Files 39 41 +2
Lines 1455 1474 +19
==========================================
+ Hits 1075 1109 +34
+ Misses 380 365 -15 ☔ View full report in Codecov by Sentry. |
stufield
force-pushed
the
improvements-to-lifting-11k
branch
from
1d72db6
to
1000a5a
Compare
- `lift_adat()` now takes a `bridge =` argument, replacing the `anno.tbl =` argument. Lifting is now performed internally for a better (and safer) user experience, without the necessity of an external annotations file. Much simpler user experience. - the majority of this refactoring was internal and the user should not experience a major disruption to the API. - new internal objects `lift_master` and `lref` as sources of internal scaling factors (lifting) - new function `is_lifted()` - closes SomaLogic#81, closes SomaLogic#78
- new function getLiftCCC() - accesses the lifting correlations between SomaScan versions for each analyte - fixed small bug with SomaReadr reference in params.R - closes SomaLogic#88
- closes SomaLogic#82
stufield
force-pushed
the
improvements-to-lifting-11k
branch
from
1000a5a
to
d7401d1
Compare
scheidec
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of PR
Main Changes
Bump version to
9001in case users want to download the dev versionClean up lifting documentation
Add lifting accessor function for Lin's CCC
getLiftCCC()SomaScan versions for each analyte
in
params.RRestructure of
lift_adat()functionalitylift_adat()now takes abridge =argument,replacing the
anno.tbl =argument. Liftingis now performed internally for a better (and safer)
user experience, without the necessity of an
external annotations file. Much simpler user experience.
and the user should not experience a major
disruption to the API.
lift_masterandlrefas sources of internal scaling factors (lifting)
is_lifted()Update
read_annotations()with 11k contentUpdate
transform()andscaleAnalytes()scaleAnalytes()now skips missing referencestransform()now has edge case protectiondrop = FALSEincase of a single analyte ADAT
Internal Use Only
Change Type
Please check the relevant box(es):