Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Visual Studio 2017 15.7 rules #1454

Merged
merged 2 commits into from Apr 9, 2018
Merged

add Visual Studio 2017 15.7 rules #1454

merged 2 commits into from Apr 9, 2018

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Apr 8, 2018 •
edited by SonarOpenCommunityAdmin

@guwirth guwirth added this to the 1.0 milestone Apr 8, 2018
@guwirth guwirth self-assigned this Apr 8, 2018
@guwirth guwirth requested a review from Bertk April 8, 2018 06:53
@guwirth guwirth changed the title support VS2017 15.7 changes add Visual Studio 2017 15.7 rules Apr 8, 2018
Bertk
Bertk approved these changes Apr 9, 2018
View reviewed changes
cxx-sensors/src/main/resources/compiler-vc.xml Outdated
@@ -14171,6 +14174,81 @@ This warning indicates that a function is being used that has been banned, and h
<remediationFunction>LINEAR</remediationFunction>
<remediationFunctionGapMultiplier>5min</remediationFunctionGapMultiplier>
</rule>


<!-- ########### VS2017 15.7 ########### -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not create a new section with version specific updates. The new rules should be added with internal key number ascending order.
We can always use Git history and commit comments to identify 'VS2017 15.7' enhancements.

@guwirth guwirth merged commit eabfe3e into SonarOpenCommunity:master Apr 9, 2018
@guwirth guwirth mentioned this pull request May 12, 2018
Closed
@guwirth guwirth deleted the VS2017.7_messages branch June 25, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bertk Bertk Bertk approved these changes

Assignees

@guwirth guwirth

Labels
enhancement
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Support VS2017 15.7 messages
2 participants
@guwirth @Bertk