Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi-values/property warning #1782

Merged
merged 1 commit into from
Jan 7, 2020
Merged

fix multi-values/property warning #1782

merged 1 commit into from
Jan 7, 2020

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Jan 6, 2020


This change is Reviewable

- WARN: Property 'xxx' is not declared as multi-values/property set but was read using 'getStringArray' method. The SonarQube plugin declaring this property should be updated.
- close #1775
@guwirth guwirth added the bug label Jan 6, 2020
@guwirth guwirth added this to the 1.3.2 milestone Jan 6, 2020
@guwirth guwirth self-assigned this Jan 6, 2020
Copy link
Contributor

@Bertk Bertk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ivangalkin ivangalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @guwirth, @ivangalkin, and @jmecosta)


sonar-c-plugin/src/main/java/org/sonar/plugins/c/CPlugin.java, line 119 at r1 (raw file):

        .multiValues(true)
        .name("Include directories")
        .description("Comma-separated list of directories to search the included files in. May be defined either"

the description has to be corrected: the web UI will provide one input box per value; it is not "comma-separated list" any more

besides that: is the change backwards compatible? will customizations done by users still correctly displayed in the UI?


sonar-c-plugin/src/main/java/org/sonar/plugins/c/CPlugin.java, line 126 at r1 (raw file):

        .build(),
      PropertyDefinition.builder(FORCE_INCLUDE_FILES_KEY)
        .multiValues(true)

same here and below

@guwirth
Copy link
Collaborator Author

guwirth commented Jan 7, 2020

@ivangalkin

Double checked this with Java. They also call it "comma-separated list". Think this is because it is in the config file still a comma-separated list and only in the UI different fields:

grafik

@guwirth guwirth merged commit eaf9df8 into SonarOpenCommunity:master Jan 7, 2020
@guwirth guwirth mentioned this pull request Feb 10, 2020
@guwirth guwirth deleted the c-multi-values-properties branch February 14, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

How to solve "The SonarQube plugin declaring this property should be updated"
3 participants