Resolve issue #4459

SonarSource · Mar 26, 2024 · a3ab425 · a3ab425
1 parent d0fefb2
commit a3ab425
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/packages/jsts/src/rules/S2699/chai.fixture.js b/packages/jsts/src/rules/S2699/chai.fixture.js
@@ -64,3 +64,6 @@ describe('chai test cases', () => {
     expect(1).to.equal(2);
   }
 });
+
+chai.expect(5).to.equal(5); // Compliant: assertion is recognized outside a {describe > it} scope
+
diff --git a/packages/jsts/src/rules/S2699/rule.ts b/packages/jsts/src/rules/S2699/rule.ts
@@ -90,7 +90,14 @@ class TestCaseAssertionVisitor {
       return;
     }
     if (isFunctionCall(node)) {
-      const functionDef = resolveFunction(this.context, node.callee);
+      const { callee } = node;
+
+      if (callee.name === 'expect') {
+        this.hasAssertions = true;
+        return;
+      }
+
+      const functionDef = resolveFunction(this.context, callee);
       if (functionDef) {
         this.visit(context, functionDef.body, visitedNodes);
       }

diff --git a/packages/jsts/src/rules/S2699/vitest.fixture.js b/packages/jsts/src/rules/S2699/vitest.fixture.js
@@ -19,6 +19,10 @@ describe('vitest test cases', () => {
     check();
   });
 
+  it('recognizes global expect as an assertion', () => {
+    expect(5).toEqual(5);
+  });
+
   function check() {
     expect(1).toEqual(2);
   }