Add new constructor without optional dependency (#3974)

SonarSource · Jun 13, 2023 · f95f3d1 · f95f3d1
1 parent dc9dcc3
commit f95f3d1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/...sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/eslint/JsTsSensor.java b/...sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/eslint/JsTsSensor.java
@@ -51,13 +51,24 @@ public class JsTsSensor extends AbstractEslintSensor {
   private boolean createWildcardTSConfig = false;
   private boolean createProgram = true;
 
+  // Constructor for SonarCloud without the optional dependency (Pico doesn't support optional dependencies)
   public JsTsSensor(
     JsTsChecks checks,
     EslintBridgeServer eslintBridgeServer,
     AnalysisWarningsWrapper analysisWarnings,
     Monitoring monitoring,
-    @Nullable JavaScriptProjectChecker javaScriptProjectChecker,
     AnalysisProcessor analysisProcessor
+  ) {
+    this(checks, eslintBridgeServer, analysisWarnings, monitoring, analysisProcessor, null);
+  }
+
+  public JsTsSensor(
+    JsTsChecks checks,
+    EslintBridgeServer eslintBridgeServer,
+    AnalysisWarningsWrapper analysisWarnings,
+    Monitoring monitoring,
+    AnalysisProcessor analysisProcessor,
+    @Nullable JavaScriptProjectChecker javaScriptProjectChecker
   ) {
     super(eslintBridgeServer, analysisWarnings, monitoring);
     this.checks = checks;

diff --git a/...r-javascript-plugin/src/test/java/org/sonar/plugins/javascript/eslint/JsTsSensorTest.java b/...r-javascript-plugin/src/test/java/org/sonar/plugins/javascript/eslint/JsTsSensorTest.java
@@ -516,10 +516,10 @@ private JsTsSensor createSensor(SensorContext ctx) {
       eslintBridgeServerMock,
       analysisWarnings,
       monitoring,
+      processAnalysis,
       ctx.runtime().getProduct() == SonarProduct.SONARLINT
         ? new SonarLintJavaScriptProjectChecker()
-        : null,
-      processAnalysis
+        : null
     );
   }