Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve S1523: decorate with ESLint's no-script-url #3920

Closed
ilia-kebets-sonarsource opened this issue May 15, 2023 · 1 comment · Fixed by #4037
Closed

Improve S1523: decorate with ESLint's no-script-url #3920

ilia-kebets-sonarsource opened this issue May 15, 2023 · 1 comment · Fixed by #4037
Assignees
@alex-sonar
Labels
mmf-3201 type: new rule Creating a new rule not existing before
Milestone
10.4

Comments

@ilia-kebets-sonarsource
Copy link
Contributor

ilia-kebets-sonarsource commented May 15, 2023 •
edited
Loading

ESLint rule definition https://eslint.org/docs/latest/rules/no-script-url

Related to S1084

maybe propose quickfix that deletes it?
@ilia-kebets-sonarsource ilia-kebets-sonarsource added type: new rule Creating a new rule not existing before mmf-3201 labels May 15, 2023
@ilia-kebets-sonarsource ilia-kebets-sonarsource added this to the 10.3.0 milestone May 15, 2023
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource removed this from the 10.3.0 milestone May 26, 2023
@alex-sonar alex-sonar added this to the 10.4 milestone Jun 13, 2023
@ilia-kebets-sonarsource
Copy link
Contributor Author

see no-misused-promises for how to merge rules

@alex-sonar alex-sonar self-assigned this Jul 24, 2023
This was referenced Jul 25, 2023
Merged
Merged
alex-sonar added a commit to SonarSource/rspec that referenced this issue Jul 25, 2023
@alex-sonar
Modify rule S1523: Raise issue for javascript: URLs (#2641)
16ab3fb 
SonarSource/SonarJS#3920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-sonar alex-sonar

Labels
mmf-3201 type: new rule Creating a new rule not existing before
Projects
None yet
Milestone
10.4
Development

Successfully merging a pull request may close this issue.

Update S1523 (code-eval): merge ESLint no-script-url SonarSource/SonarJS
4 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource @victor-diez-sonarsource @alex-sonar