Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S2699 (assertions-in-tests): Detect expect provided by the test callback on concurrent tests #4507

Closed
yassin-kammoun-sonarsource opened this issue Jan 17, 2024 · 1 comment · Fixed by #4629
Closed

Fix FP S2699 (assertions-in-tests): Detect expect provided by the test callback on concurrent tests #4507

yassin-kammoun-sonarsource opened this issue Jan 17, 2024 · 1 comment · Fixed by #4629
Labels
must-have type: false positive Issue is reported when it should NOT be
Milestone
10.13

Comments

@yassin-kammoun-sonarsource
Copy link
Contributor

https://community.sonarsource.com/t/vitest-and-describe-concurrent-tests-should-include-assertions/107121
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added the type: false positive Issue is reported when it should NOT be label Jan 17, 2024
@ilia-kebets-sonarsource ilia-kebets-sonarsource added this to the 10.13 milestone Mar 26, 2024
@ericmorand-sonarsource
Copy link
Contributor

ericmorand-sonarsource commented Mar 26, 2024 •
edited

This issue is fixed by the fix provided for #4459.

We'll just add a test to cover the case.

ericmorand-sonarsource added a commit to ericmorand-sonarsource/SonarJS that referenced this issue Mar 26, 2024
@ericmorand-sonarsource
Resolve issue SonarSource#4507
a1e8a9f
Merged
ericmorand-sonarsource added a commit to ericmorand-sonarsource/SonarJS that referenced this issue Mar 26, 2024
@ericmorand-sonarsource
Resolve issue SonarSource#4507
2ae3754
vdiez pushed a commit that referenced this issue Mar 27, 2024
@ericmorand-sonarsource
Resolve issue #4507 (#4629)
911655e
@ericmorand-sonarsource ericmorand-sonarsource removed their assignment Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
must-have type: false positive Issue is reported when it should NOT be
Projects
None yet
Milestone
10.13
Development

Successfully merging a pull request may close this issue.

Resolve issue #4507 ericmorand-sonarsource/SonarJS
3 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource @ericmorand-sonarsource