Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S4323 (use-type-alias): Ignore nullable types #4530

Closed
ilia-kebets-sonarsource opened this issue Jan 25, 2024 · 1 comment · Fixed by #4543
Closed

Fix FP S4323 (use-type-alias): Ignore nullable types #4530

ilia-kebets-sonarsource opened this issue Jan 25, 2024 · 1 comment · Fixed by #4543
Assignees
@yassin-kammoun-sonarsource
Labels
mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934
Milestone
10.12

Comments

@ilia-kebets-sonarsource
Copy link
Contributor

Add exception when the union is: <primitive-type> | null | undefined.

Examples:
@ilia-kebets-sonarsource ilia-kebets-sonarsource added the mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934 label Jan 25, 2024
@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title Fix FP S4323: for optional primitive type Fix FP S4323 (use-type-alias): for optional primitive type Jan 25, 2024
@yassin-kammoun-sonarsource
Copy link
Contributor

I would propose to generalize the exception to any kind of nullable type, that is, T | null | undefined where T can be anything. I don't think it makes sense to restrict ourselves to primitive types only.

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title Fix FP S4323 (use-type-alias): for optional primitive type Fix FP S4323 (use-type-alias): Ignore nullable types Jan 31, 2024
Merged
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource added this to the 10.12 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource

Labels
mmf-2934 https://sonarsource.atlassian.net/browse/MMF-2934
Projects
None yet
Milestone
10.12
Development

Successfully merging a pull request may close this issue.

Fix FP S4323 (use-type-alias): Ignore nullable types SonarSource/SonarJS
3 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource @ericmorand-sonarsource