Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S4323 (use-type-alias): Ignore nullable types #4543

Merged
merged 2 commits into from Feb 1, 2024
Merged

Fix FP S4323 (use-type-alias): Ignore nullable types #4543

merged 2 commits into from Feb 1, 2024

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #4530

@ericmorand-sonarsource ericmorand-sonarsource dismissed their stale review January 31, 2024 16:41

I forgot to check for existence of the updated documentation

@ericmorand-sonarsource
Copy link
Contributor

@yassin-kammoun-sonarsource, should I wait for the updated documentation to be included to perform my review?

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@yassin-kammoun-sonarsource
Copy link
Contributor Author

@yassin-kammoun-sonarsource, should I wait for the updated documentation to be included to perform my review?

Not sure why, but I am unable to pull the doc changes from the RSPEC PR for now.
You can review the RSPEC changes directly in the corresponding PR and proceed with the review of the implementation change. In the meantime, I will try to push the RSPEC changes here as well somehow.

ericmorand-sonarsource
ericmorand-sonarsource approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ericmorand-sonarsource ericmorand-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 1ab3045 into master Feb 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmorand-sonarsource ericmorand-sonarsource ericmorand-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FP S4323 (use-type-alias): Ignore nullable types
2 participants
@yassin-kammoun-sonarsource @ericmorand-sonarsource