Add rule S4822 ('no-try-promise') for TS #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
force-pushed
the
issue-1533
branch
from
ffeb4c9
to
a258dfa
Compare
vilchik-elena
requested changes
Oct 29, 2019
| @@ -0,0 +1,129 @@ | |||
| function returningPromise() { | |||
There was a problem hiding this comment.
I think we should not have entire unit test the rule here. The point of this test is just to make sure rule is executed normally.
Could you keep only couple main cases?
yassin-kammoun-sonarsource
force-pushed
the
issue-1533
branch
from
a258dfa
to
e4f4a11
Compare
vilchik-elena
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1533