Rule S4507: debug features activated in production (deprecate S1442 and S1525) #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilchik-elena
force-pushed
the
issue-1839
branch
from
ee57107
to
381b28e
Compare
saberduck
approved these changes
Aug 11, 2020
| const { callee, arguments: args } = callExpression; | ||
| if ( | ||
| callee.type === 'MemberExpression' && | ||
| callee.property.type === 'Identifier' && |
There was a problem hiding this comment.
you can use isIdentifier from utils
| } | ||
| } | ||
|
|
||
| function conditional(context: Rule.RuleContext) { |
There was a problem hiding this comment.
I would suggest more descriptive name, like isInsideConditional , hasConditionalAncestor
|
|
||
| function conditional(context: Rule.RuleContext) { | ||
| const ancestors = context.getAncestors(); | ||
| return !!ancestors.find(ancestor => ancestor.type === 'IfStatement'); |
There was a problem hiding this comment.
you can use ancestors.some and avoid !!
|
Kudos, SonarQube Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1839