Update rules metadata #2657
Merged
Update rules metadata #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilchik-elena
commented
Jun 4, 2021
| <h2>Ask Yourself Whether</h2> | ||
| <ul> | ||
| <li> the cookie is for instance a <em>session-cookie</em> not designed to be sent over non-HTTPS communication. </li> | ||
| <li> it's not sure that the website contains <a href="https://developer.mozilla.org/fr/docs/Web/Security/Mixed_content">mixed content</a> or not (ie | ||
| HTTPS everywhere or not) </li> | ||
| <li> it’s not sure that the website contains <a href="https://developer.mozilla.org/en-US/docs/Web/Security/Mixed_content">mixed content</a> or not |
There was a problem hiding this comment.
In fact I think ’ fits better here
From wiki: https://en.wikipedia.org/wiki/Apostrophe
In English, it is used for four purposes... marking of the omission of one or more letters, e.g. the contraction of "do not" to "don't".
There was a problem hiding this comment.
so, it should be apostrophe not backtick? I don't follow
There was a problem hiding this comment.
Apostrophe: ’
Backtick: `
Quote: '
We used quote, it's correctly changed to apostrophe
|
SonarQube Quality Gate
|
saberduck
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.