Add quick fix for S3415 ('inverted-assertion-arguments') #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The newly added test file should be dropped once #3047 is done, and the quick fix assertions should be moved to the comment-based test file. |
vilchik-elena
requested changes
Mar 17, 2022
| import { rule } from 'rules/inverted-assertion-arguments'; | ||
| import { RuleTester } from 'eslint'; | ||
|
|
||
| const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } }); |
There was a problem hiding this comment.
let's add comment that this rule is tested in another file and that here we just testing fixes.
| const assert = require('chai').should(); | ||
| describe('suite', () => { | ||
| it('test', () => { | ||
| should.fail(42, aNumber); |
There was a problem hiding this comment.
tbh instead of testing different APIs, I would focus on more complex expressions (multiline, spaces)
|
SonarQube Quality Gate
|
vilchik-elena
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3015