Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quick fix for S1763 ('no-unreachable') #3051

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #3008

@sonarsource-next
Copy link

sonarsource-next bot commented Mar 16, 2022

while (a()) {
b();
break;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not great to have this empty line but that's minor and I don't think it's worth it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not great indeed -_-. I actually tried to remove it, but there were weird side-effects.

@vilchik-elena vilchik-elena merged commit 44471ed into master Mar 17, 2022
@vilchik-elena vilchik-elena deleted the issue-3008 branch March 17, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add quick fix for S1763: All code should be reachable
2 participants