Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quick fix for S1128 (unused-import) #3059

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Add quick fix for S1128 (unused-import) #3059

merged 4 commits into from
Mar 22, 2022

Conversation

vilchik-elena
Copy link
Contributor

Fixes #3004

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can maybe add test cases for type imports and import aliases just to be exhaustive, otherwise lgtm.

@vilchik-elena vilchik-elena enabled auto-merge (squash) March 22, 2022 08:51
@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@vilchik-elena vilchik-elena merged commit 8ee58e3 into master Mar 22, 2022
@vilchik-elena vilchik-elena deleted the issue-3004 branch March 22, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add quick fix for S1128: Unnecessary imports should be removed
2 participants
@vilchik-elena @yassin-kammoun-sonarsource