Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper functions searchable documentation #3506

Merged
merged 43 commits into from
Feb 3, 2023
Merged

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource commented Oct 26, 2022

@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ilia-kebets-sonarsource
Copy link
Contributor Author

TODOs:

  • it might be nice to display the full signature in the search result, especially when the found term is a parameter, to make it easier to understand what was found
  • I'd suggest to separate the different types of search result ('Types', vs 'Function', vs 'Class') if possible:
    Example: looking for 'isStringLiteral' I type 'literal' or 'string' in the search bar. The first result is the type 'StringLiteral'. It'd be nice to
    either clearly indicate it's a 'type' result (with the C, T, F, V icons on the side), or separate the types/variables/functions result with a clear separation bar or something. Maybe even put types at the end?
  • minor UI remark -> if I'm in a element of the "Mocha" module (such as inside the 'isTestCase' function description), I clearly see on the right menu the vertical bar on the module hierarchy being highlighted, i.e. the "|" of " | SonarJS linter helper functions" and " | Mocha". If I'm in the description of an element from "SonarJS linter helper functions" (such as inside the 'flattenArgs' function description), there's no vertical bar highlight "|" next to the right "SonarJS linter helper functions" menu element.
  • In some descriptions there are links to the defined types (example, in 'Mocha.extractTestCase' the 'TestCase' type is clickable to directly go on the page), and in others there aren't (example 'Express.attemptFindAppInjection' the 'RuleContext' is not clickable)

@ilia-kebets-sonarsource ilia-kebets-sonarsource marked this pull request as ready for review February 3, 2023 07:36
@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants