Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S2424 (no-built-in-override): Remove System from globals #3620

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Fix FP S2424 (no-built-in-override): Remove System from globals #3620

merged 3 commits into from
Jan 4, 2023

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource commented Jan 4, 2023 •
edited

Fixes #3541

francoismora
francoismora approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@francoismora francoismora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit b76b847 into master Jan 4, 2023
@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the issue-3541-remove-system-from-globals branch January 4, 2023 15:56
@saberduck saberduck mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoismora francoismora francoismora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FP S2424: Remove System from globals
2 participants
@ilia-kebets-sonarsource @francoismora