Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S6442 (no-hook-setter-in-body): Shouldn't raise when used conditionally #3622

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Fix FP S6442 (no-hook-setter-in-body): Shouldn't raise when used conditionally #3622

merged 2 commits into from
Jan 5, 2023

Conversation

saberduck
Copy link
Contributor

Fixes #3516

@ilia-kebets-sonarsource
Copy link
Contributor

ilia-kebets-sonarsource commented Jan 5, 2023 •
edited

I proposed a small function name refactor.

Should you also apply the RSPEC change that Gab mentioned in "corrections" in #3516?

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments, LGTM.

I Fixed the PR title to reflect https://xtranet-sonarsource.atlassian.net/wiki/spaces/LANG/pages/2567241836/Commit+and+Tickets+Guidelines

@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title Modify S6442: Shouldn't raise when used conditionally Fix FP S6442 (no-hook-setter-in-body): Shouldn't raise when used conditionally Jan 5, 2023
@saberduck @ilia-kebets-sonarsource
Apply suggestions from code review
9a2e7ee 
Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
@saberduck saberduck enabled auto-merge (squash) January 5, 2023 14:47
@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@saberduck saberduck merged commit 262a68a into master Jan 5, 2023
@saberduck saberduck deleted the issue-3516 branch January 5, 2023 16:41
@saberduck saberduck mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FP in S6442 improve corner case and fix rule title
2 participants
@saberduck @ilia-kebets-sonarsource