Deprecate S2814 (no-redeclare) for TypeScript
#3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilchik-elena
requested changes
Jan 10, 2023
| @@ -49,7 +50,10 @@ public void define(Context context) { | |||
| NewRule commentRegularExpression = repository.rule("S124"); | |||
| commentRegularExpression.setTemplate(true); | |||
|
|
|||
| // deprecated for Typescript: https://github.com/SonarSource/SonarJS/issues/3580 | |||
| NewRule redeclaredVariables = repository.rule("S2814"); | |||
There was a problem hiding this comment.
for the variable name use eslint key or java class name
| @@ -95,6 +95,7 @@ void sonar_way_ts() { | |||
| assertThat(profile.rules()).extracting("repoKey").containsOnly(CheckList.TS_REPOSITORY_KEY); | |||
| assertThat(profile.rules().size()).isGreaterThan(100); | |||
| assertThat(profile.rules()).extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey).contains("S5122"); | |||
| assertThat(profile.rules()).extracting(BuiltInQualityProfilesDefinition.BuiltInActiveRule::ruleKey).doesNotContain("S2814"); | |||
There was a problem hiding this comment.
Assert that JS profile has it
| @@ -49,7 +50,10 @@ public void define(Context context) { | |||
| NewRule commentRegularExpression = repository.rule("S124"); | |||
| commentRegularExpression.setTemplate(true); | |||
|
|
|||
| // deprecated for Typescript: https://github.com/SonarSource/SonarJS/issues/3580 | |||
| NewRule redeclaredVariables = repository.rule("S2814"); | |||
| redeclaredVariables.setStatus(RuleStatus.DEPRECATED); | |||
There was a problem hiding this comment.
can we unit test it?
|
SonarQube Quality Gate
|
vilchik-elena
changed the title
no-redeclare) for TypeScript
vilchik-elena
approved these changes
Jan 11, 2023
ilia-kebets-sonarsource
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit 4c0766e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3580
Note: we failed to add
Deprecatedsection to the rule description