Remove unused code #4087
Merged
Remove unused code #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
hashicorp-vault-sonar-prod
bot
assigned saberduck and unassigned victor-diez-sonarsource
alex-sonar
reviewed
Aug 23, 2023
| @@ -17,36 +17,34 @@ | |||
| * along with this program; if not, write to the Free Software Foundation, | |||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | |||
| */ | |||
| import { FileType, readFile } from '@sonar/shared/helpers'; | |||
| import { FileType, readFile } from '@sonar/shared/helpers/index'; | |||
| import { EmbeddedAnalysisInput } from '@sonar/jsts/embedded'; | |||
| import { JsTsAnalysisInput } from '@sonar/jsts'; | |||
There was a problem hiding this comment.
IMHO we should avoid circular references between packages, i.e. the shared should not import anything back from jsts and other sensors
saberduck
approved these changes
Aug 24, 2023
hashicorp-vault-sonar-prod
bot
assigned victor-diez-sonarsource and unassigned saberduck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up remaining code from tsconfigs revert