Fix S6535 (unnecessary-character-escapes): Disambiguate conflicting message ids #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const noUselessEscapeRule = eslintRules['no-useless-escape']; | ||
| const noNonoctalDecimalEscapeRule = eslintRules['no-nonoctal-decimal-escape']; | ||
|
|
||
| /** | ||
| * We replace the message id 'escapeBackslash' of 'no-nonoctal-decimal-escape' with 'otherEscapeBackslash'. |
There was a problem hiding this comment.
Maybe rename it nonOctalEscapeBacklash?
There was a problem hiding this comment.
👍
ilia-kebets-sonarsource
approved these changes
Aug 25, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3987
S6535 implementation consists of merging ESLint rules
no-useless-escapeandno-nonoctal-decimal-escape. However, both share a common message idescapeBackslashwith a different description for their respective suggestions. Because this wasn't noticed at the time of merging the rules, the message idescapeBackslashfromno-nonoctal-decimal-escapeused to overwrite the one fromno-useless-escape. This is why not only the suggestion messages were sometimes confusing but also why the data interpolation of some suggestions didn't occur.