New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node.js 20 as a possible recommended version #4110
Conversation
static final List<Integer> RECOMMENDED_NODE_VERSIONS = Arrays.asList(16, 18, 20); | ||
static final List<Integer> ALL_RECOMMENDED_NODE_VERSIONS = Arrays.asList(14, 16, 18, 20); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we should get rid of these lists and rework the deprecation logic as well as the logs so that we only test whether the actual node version is an even number greater or equal than the current value of MIN_RECOMMENDED_NODE_VERSION
. This means we would no longer tell explicitly which versions are recommended. Users would need to read the analyzer documentation to figure out which one, which will redirect them to Node.js LTS page.
Maybe it's not worth the effort since we will soon embed Node.js runtime. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not worth the effort with our current plans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
cd5e151
to
9930de8
Compare
@yassin-kammoun-sonarsource you need to rebase, I am not sure what changed |
I renamed a package in a previous commit. Nothing serious. |
SonarQube Quality Gate |
Fixes #4013