Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node.js 20 as a possible recommended version #4110

Merged
merged 4 commits into from Aug 30, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #4013

Comment on lines 59 to 60
static final List<Integer> RECOMMENDED_NODE_VERSIONS = Arrays.asList(16, 18, 20);
static final List<Integer> ALL_RECOMMENDED_NODE_VERSIONS = Arrays.asList(14, 16, 18, 20);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we should get rid of these lists and rework the deprecation logic as well as the logs so that we only test whether the actual node version is an even number greater or equal than the current value of MIN_RECOMMENDED_NODE_VERSION. This means we would no longer tell explicitly which versions are recommended. Users would need to read the analyzer documentation to figure out which one, which will redirect them to Node.js LTS page.

Maybe it's not worth the effort since we will soon embed Node.js runtime. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not worth the effort with our current plans

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saberduck
Copy link
Contributor

@yassin-kammoun-sonarsource you need to rebase, I am not sure what changed

@yassin-kammoun-sonarsource
Copy link
Contributor Author

@yassin-kammoun-sonarsource you need to rebase, I am not sure what changed

I renamed a package in a previous commit. Nothing serious.

@sonarqube-next
Copy link

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit c05121d into master Aug 30, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecation message to support Node v20
2 participants