Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change run-node error message when Node.js is not found #4112

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

victor-diez-sonarsource
Copy link
Contributor

Fixes #4058

@victor-diez-sonarsource
Copy link
Contributor Author

Can someone using Mac verify that the message actually has changed? @ilia-kebets-sonarsource @yassin-kammoun-sonarsource @saberduck

@sonarqube-next
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before

Screenshot 2023-08-31 at 11 49 56

After

Screenshot 2023-08-31 at 11 54 23

@victor-diez-sonarsource victor-diez-sonarsource merged commit 90d0f93 into master Aug 31, 2023
18 checks passed
@victor-diez-sonarsource victor-diez-sonarsource deleted the hide-run-node-message branch August 31, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid message from run-node in the logs
3 participants