Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename remaining ESLint bridge-related components #4121

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Rename remaining ESLint bridge-related components #4121

merged 2 commits into from
Aug 30, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Continuation of #4070.

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ilia-kebets-sonarsource
ilia-kebets-sonarsource requested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check for folders as well?
We have sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/eslint/

@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit ef11a0e into master Aug 30, 2023
17 checks passed
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource deleted the yassin/rename-eslint-bridge branch August 30, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource