Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FP S4123 (no-invalid-await): Improve thenable type detection #4123

Merged
merged 1 commit into from Aug 31, 2023
Merged

Fix FP S4123 (no-invalid-await): Improve thenable type detection #4123

merged 1 commit into from Aug 31, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #4113

@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

victor-diez-sonarsource
victor-diez-sonarsource approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@victor-diez-sonarsource victor-diez-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit f6043db into master Aug 31, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-diez-sonarsource victor-diez-sonarsource victor-diez-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FP S4123 (no-invalid-await): don't flag when function returns a thenable object
2 participants
@yassin-kammoun-sonarsource @victor-diez-sonarsource