Add rule S6747 (no-unknown-property): JSX elements should not use unknown properties and attributes
#4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
changed the title
no-unknown-property): Disallow usage of unknown DOM propertyno-unknown-property): JSX elements should not use unknown properties and attributes
yassin-kammoun-sonarsource
force-pushed
the
i4144
branch
4 times, most recently
from
2387086
to
bf1dcdb
Compare
| @@ -17,11 +17,11 @@ | |||
| * along with this program; if not, write to the Free Software Foundation, | |||
There was a problem hiding this comment.
The changes on this file were required to also consider .jsx files triggering quick fixes.
| @Rule(key = "S6747") | ||
| public class NoUnknownPropertyCheck implements EslintBasedCheck { | ||
|
|
||
| @RuleProperty( |
There was a problem hiding this comment.
In general, I would avoid as much as possible to include properties to a rule. However, if we don't provide this feature, I am afraid too many users will complain about false positives.
Please let me know if that makes sense to you, or if we should drop that property :)
There was a problem hiding this comment.
Yes, I agree that it is necessary - that was my first thought when I was reading the rule source.
…nknown properties and attributes
yassin-kammoun-sonarsource
force-pushed
the
i4144
branch
from
bf1dcdb
to
cd2181b
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4144