Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S6748 (react/no-children-prop): React children should not be passed as prop #4149

Merged
merged 4 commits into from Sep 11, 2023
Merged

Create rule S6748 (react/no-children-prop): React children should not be passed as prop #4149

merged 4 commits into from Sep 11, 2023

Conversation

alex-sonar
Copy link
Contributor

Fixes #4129

@alex-sonar alex-sonar marked this pull request as ready for review September 6, 2023 14:51
@sonarqube-next
Copy link

sonarqube-next bot commented Sep 6, 2023

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alex-sonar alex-sonar merged commit 2afbb04 into master Sep 11, 2023
18 checks passed
@alex-sonar alex-sonar deleted the issue-4129 branch September 11, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create rule S6748 (react/no-children-prop): React children should not be passed as prop
2 participants
@alex-sonar @yassin-kammoun-sonarsource